From a4a5cce8d83e2d0b21f79e86d058dfd42242dd16 Mon Sep 17 00:00:00 2001
From: Yusuf Kandemir <yusuf.kandemir@outlook.com.tr>
Date: Mon, 17 Dec 2018 19:20:18 +0300
Subject: [PATCH] Refactored long switch case with duplicate code to lookup
 table

This is more performant(can be ignored but an extra) due to nature of lookup tables. Also it is more compact and has ease of extension. It is a little bit scary at the first sight though.
---
 src/MicrodataDOMElement.php | 72 ++++++++++++++++---------------------
 1 file changed, 30 insertions(+), 42 deletions(-)

diff --git a/src/MicrodataDOMElement.php b/src/MicrodataDOMElement.php
index 541cfe6..95acff7 100644
--- a/src/MicrodataDOMElement.php
+++ b/src/MicrodataDOMElement.php
@@ -4,6 +4,27 @@ namespace YusufKandemir\MicrodataParser;
 
 class MicrodataDOMElement extends \DOMElement
 {
+    /** @var array "tag name" to "attribute name" mapping */
+    private static $tagNameLookup = [
+        'audio' => 'src',
+        'embed' => 'src',
+        'iframe' => 'src',
+        'img' => 'src',
+        'source' => 'src',
+        'track' => 'src',
+        'video' => 'src',
+        'a' => 'href',
+        'area' => 'href',
+        'link' => 'href',
+        'object' => 'data',
+        'data' => 'value',
+        'meter' => 'value',
+        'time' => 'datetime',
+    ];
+
+    /** @var array Attributes that have absolute values */
+    private static $absoluteAttributes = ['src', 'href', 'data',];
+
     /**
      * @see https://www.w3.org/TR/2018/WD-microdata-20180426/#dfn-item-properties for details of algorithm
      *
@@ -87,51 +108,18 @@ class MicrodataDOMElement extends \DOMElement
 
         $base = $this->ownerDocument->documentURI;
 
-        switch ($this->tagName) {
-            case 'audio':
-            case 'embed':
-            case 'iframe':
-            case 'img':
-            case 'source':
-            case 'track':
-            case 'video':
-                if ($this->hasAttribute('src')) {
-                    $result = $this->getAttribute('src');
+        $value = '';
 
-                    // @todo check against protocol relative urls like "//example.com/test.jpg"
-                    return $this->isAbsoluteUri($result) ? $result : $base.$result;
-                }
-                // No break
-            case 'a':
-            case 'area':
-            case 'link':
-                if ($this->hasAttribute('href')) {
-                    $result = $this->getAttribute('href');
+        if (\array_key_exists($this->tagName, self::$tagNameLookup)) {
+            $attribute = self::$tagNameLookup[$this->tagName];
+            $value = $this->getAttribute($attribute);
 
-                    return $this->isAbsoluteUri($result) ? $result : $base.$result;
-                }
-                // No break
-            case 'object':
-                if ($this->hasAttribute('data')) {
-                    $result = $this->getAttribute('data');
-
-                    return $this->isAbsoluteUri($result) ? $result : $base.$result;
-                }
-                // No break
-            case 'data':
-            case 'meter':
-                if ($this->hasAttribute('value')) {
-                    return $this->getAttribute('value');
-                }
-                // No break
-            case 'time':
-                if ($this->hasAttribute('datetime')) {
-                    return $this->getAttribute('datetime');
-                }
-                // No break
-            default:
-                return $this->textContent;
+            if (!empty($value) && \in_array($attribute, self::$absoluteAttributes) && !$this->isAbsoluteUri($value)) {
+                $value = $base . $value;
+            }
         }
+
+        return $value ?: $this->textContent;
     }
 
     /**