Commit Graph

15 Commits

Author SHA1 Message Date
Yusuf Kandemir dcd54585cc Make handling of absolute uris changable through a callback 2018-12-17 20:15:13 +03:00
Yusuf Kandemir a4a5cce8d8 Refactored long switch case with duplicate code to lookup table
This is more performant(can be ignored but an extra) due to nature of lookup tables. Also it is more compact and has ease of extension. It is a little bit scary at the first sight though.
2018-12-17 19:20:18 +03:00
Yusuf Kandemir e26f84fd0c Refactoring by extracting a method 2018-12-16 12:23:09 +03:00
Yusuf Kandemir 1ce3f5fd17 Added references to W3C Specification in docblocks
This is much better for understanding whats going on. Also as the reference links are pointing to 26/04/2018 version, it helps understanding if things have been changed etc.
2018-12-14 10:05:33 +03:00
Yusuf Kandemir 9eaf3cbcfa Docblocking and type hinting 2018-12-13 09:50:04 +03:00
Yusuf Kandemir a5bfeb5ec5 Added itemref support and test
The test also tests "src based tags" as can be seen in dataset name
2018-11-12 19:11:52 +03:00
Yusuf Kandemir 5923db266c Formatting 2018-11-11 23:19:53 +03:00
Yusuf Kandemir ee7eaf1317 Some refactoring 2018-11-11 23:18:13 +03:00
Yusuf Kandemir 9de66c3b40 Added no break comments
This is for both PSR-2 and avoiding pitfalls(that is why it is in PSR-2).
2018-11-11 22:59:59 +03:00
Yusuf Kandemir 9dd85c1e5b Some formatting 2018-11-11 22:55:36 +03:00
Yusuf Kandemir 7bba0cbaa6 Little formatting 2018-11-11 22:54:43 +03:00
Yusuf Kandemir 4cdd720082 Refactoring 2018-11-11 22:47:37 +03:00
Yusuf Kandemir faeb1f97a0 Some refactoring 2018-11-11 21:53:08 +03:00
Yusuf Kandemir 65f35e747b Removed comments that only shows steps
This steps was only helpful while implementing the algorithm. And could be useful while comparing with the W3C specification, but they take up too much space.
2018-11-11 21:00:12 +03:00
Yusuf Kandemir 0e2f17ac37 Extracted methods to a class 2018-11-11 20:49:54 +03:00