diff --git a/doc/ObjectUserdata.md b/doc/ObjectUserdata.md new file mode 100644 index 0000000..3683a1d --- /dev/null +++ b/doc/ObjectUserdata.md @@ -0,0 +1,5 @@ +# Object UserData + +There is no support for userdata on `WebSocketInterface`, `WebSocketConnection` or `ConnectionGroup`. + +The rationale for this is that the connections can be easily managed using `SplObjectStorage` to link to a data object. Similarly, for groups, the names should be unique and can be used for lookups. diff --git a/src/Debug/HexDumpTrait.php b/src/Debug/HexDumpTrait.php deleted file mode 100644 index 6c5066d..0000000 --- a/src/Debug/HexDumpTrait.php +++ /dev/null @@ -1,28 +0,0 @@ -assertEquals(3, count($r)); } -} \ No newline at end of file +} diff --git a/tests/WebSocketMiddlewareTest.php b/tests/WebSocketMiddlewareTest.php index 51b024f..4c6989a 100644 --- a/tests/WebSocketMiddlewareTest.php +++ b/tests/WebSocketMiddlewareTest.php @@ -6,6 +6,7 @@ use PHPUnit\Framework\Attributes\CoversClass; use React\Http\Message\ServerRequest; #[CoversClass(WebSocketMiddleware::class)] +#[CoversClass(WebSocketConnection::class)] class WebSocketMiddlewareTest extends \PHPUnit\Framework\TestCase { @@ -54,4 +55,4 @@ class InvokableDummy public function test() { } -} \ No newline at end of file +}