From 6f45622b09a19c63bbeab23f6ddb95cbf117afc8 Mon Sep 17 00:00:00 2001
From: Christopher Vagnetoft <cvagnetoft@gmail.com>
Date: Fri, 23 Feb 2024 22:44:39 +0100
Subject: [PATCH] Removed debugging code, tweaks to tests

---
 doc/ObjectUserdata.md               |  5 +++++
 src/Debug/HexDumpTrait.php          | 28 ----------------------------
 tests/Group/ConnectionGroupTest.php |  5 ++++-
 tests/WebSocketMiddlewareTest.php   |  3 ++-
 4 files changed, 11 insertions(+), 30 deletions(-)
 create mode 100644 doc/ObjectUserdata.md
 delete mode 100644 src/Debug/HexDumpTrait.php

diff --git a/doc/ObjectUserdata.md b/doc/ObjectUserdata.md
new file mode 100644
index 0000000..3683a1d
--- /dev/null
+++ b/doc/ObjectUserdata.md
@@ -0,0 +1,5 @@
+# Object UserData
+
+There is no support for userdata on `WebSocketInterface`, `WebSocketConnection` or `ConnectionGroup`.
+
+The rationale for this is that the connections can be easily managed using `SplObjectStorage` to link to a data object. Similarly, for groups, the names should be unique and can be used for lookups.
diff --git a/src/Debug/HexDumpTrait.php b/src/Debug/HexDumpTrait.php
deleted file mode 100644
index 6c5066d..0000000
--- a/src/Debug/HexDumpTrait.php
+++ /dev/null
@@ -1,28 +0,0 @@
-<?php
-
-namespace NoccyLabs\React\WebSocket\Debug;
-
-trait HexDumpTrait
-{
-
-    private function hexdump($data): void
-    {
-        printf("_____  *%4d\n", strlen($data));
-        $rows = str_split($data, 16);
-        $offs = 0;
-        foreach ($rows as $row) {
-            $h = []; $a = [];
-            for ($n = 0; $n < 16; $n++) {
-                if ($n < strlen($row)) {
-                    $h[] = sprintf("%02x%s", ord($row[$n]), ($n==7)?"  ":" ");
-                    $a[] = sprintf("%s%s", (ctype_print($row[$n])?$row[$n]:"."), ($n==7)?" ":"");
-                } else {
-                    $h[] = (($n==7)?"    ":"   ");
-                    $a[] = (($n==7)?"  ":" ");
-                }
-            }
-            printf("%04x | %s | %s\n", 16 * $offs++, join("", $h), join("", $a));
-        }
-    }
-
-}
diff --git a/tests/Group/ConnectionGroupTest.php b/tests/Group/ConnectionGroupTest.php
index db7ea97..50e7932 100644
--- a/tests/Group/ConnectionGroupTest.php
+++ b/tests/Group/ConnectionGroupTest.php
@@ -3,11 +3,14 @@
 namespace NoccyLabs\React\WebSocket\Group;
 
 use NoccyLabs\React\WebSocket\WebSocketConnection;
+use NoccyLabs\React\WebSocket\WebSocketProtocol;
 use PHPUnit\Framework\Attributes\CoversClass;
 use React\Http\Message\ServerRequest;
 use React\Stream\ThroughStream;
 
 #[CoversClass(ConnectionGroup::class)]
+#[CoversClass(WebSocketConnection::class)]
+#[CoversClass(WebSocketProtocol::class)]
 class ConnectionGroupTest extends \PHPUnit\Framework\TestCase
 {
 
@@ -49,4 +52,4 @@ class ConnectionGroupTest extends \PHPUnit\Framework\TestCase
         $this->assertEquals(3, count($r));
     }
 
-}
\ No newline at end of file
+}
diff --git a/tests/WebSocketMiddlewareTest.php b/tests/WebSocketMiddlewareTest.php
index 51b024f..4c6989a 100644
--- a/tests/WebSocketMiddlewareTest.php
+++ b/tests/WebSocketMiddlewareTest.php
@@ -6,6 +6,7 @@ use PHPUnit\Framework\Attributes\CoversClass;
 use React\Http\Message\ServerRequest;
 
 #[CoversClass(WebSocketMiddleware::class)]
+#[CoversClass(WebSocketConnection::class)]
 class WebSocketMiddlewareTest extends \PHPUnit\Framework\TestCase
 {
 
@@ -54,4 +55,4 @@ class InvokableDummy
     public function test()
     {
     }
-}
\ No newline at end of file
+}