noccy
/
microdata-parser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Extract data related testing logic to a TestCase 

This is obviously for cleaner tests and reusability
This commit is contained in:
Yusuf Kandemir 2018-12-26 08:45:06 +03:00
parent 7bbf744a76
commit 9b723a4c42
2 changed files with 52 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
tests/DataDrivenTestCase.php Normal file
View File

@ -0,0 +1,51 @@
<?php
namespace YusufKandemir\MicrodataParser\Tests;
class DataDrivenTestCase extends \PHPUnit\Framework\TestCase
{
protected function setUp()
{
libxml_use_internal_errors(true); // Ignore warnings of DOMDocument::loadHTML check
}
public function data()
{
return [
// https://www.w3.org/TR/microdata/#ex-jsonconv
'W3C Example' => [
$this->getTestData('W3C', 'source.html', 'result.json')
],
'Itemref & src based tags' => [
$this->getTestData('Itemref', 'source.html', 'result.json')
],
'Object & Data tags' => [
$this->getTestData('Object & Data', 'source.html', 'result.json')
],
'Itemid & Content attributes' => [
$this->getTestData('Itemid & Content', 'source.html', 'result.json')
],
];
}
private function getTestData($folderName, $sourceName, $resultName)
{
$folderPath = __DIR__.'/data/'.$folderName.'/';
$source = file_get_contents($folderPath . $sourceName);
$result = file_get_contents($folderPath . $resultName);
$uri = '';
// Set $uri if URI specified in test data
if (preg_match('/<!-- URI: (.*) -->/', $source, $matches)) {
$uri = $matches[1];
}
return [
'path' => $folderPath . $sourceName,
'uri' => $uri,
'source' => $source, // HTML String
'result' => $result, // JSON String
];
}
}

49
tests/MicrodataParserTest.php
View File

@ -5,13 +5,8 @@ namespace YusufKandemir\MicrodataParser\Tests;
use YusufKandemir\MicrodataParser\MicrodataDOMDocument;
use YusufKandemir\MicrodataParser\MicrodataParser;
class MicrodataParserTest extends \PHPUnit\Framework\TestCase
class MicrodataParserTest extends DataDrivenTestCase
{
protected function setUp()
{
libxml_use_internal_errors(true); // Ignore warnings of DOMDocument::loadHTML check
}
protected function getParser($data)
{
$dom = new MicrodataDOMDocument;
@ -79,46 +74,4 @@ class MicrodataParserTest extends \PHPUnit\Framework\TestCase
$this->assertContains($baseUri, $resultAfterUri);
}
/**
* @todo Provide more test data
*/
public function data()
{
return [
// https://www.w3.org/TR/microdata/#ex-jsonconv
'W3C Example' => [
$this->getTestData('W3C', 'source.html', 'result.json')
],
'Itemref & src based tags' => [
$this->getTestData('Itemref', 'source.html', 'result.json')
],
'Object & Data tags' => [
$this->getTestData('Object & Data', 'source.html', 'result.json')
],
'Itemid & Content attributes' => [
$this->getTestData('Itemid & Content', 'source.html', 'result.json')
],
];
}
private function getTestData($folderName, $sourceName, $resultName)
{
$folderPath = __DIR__.'/data/'.$folderName.'/';
$source = file_get_contents($folderPath . $sourceName);
$result = file_get_contents($folderPath . $resultName);
$uri = '';
// Set $uri if URI specified in test data
if (preg_match('/<!-- URI: (.*) -->/', $source, $matches)) {
$uri = $matches[1];
}
return [
'uri' => $uri,
'source' => $source, // HTML String
'result' => $result, // JSON String
];
}
}