noccy/php-makephar
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed issue with boolean options evaluating to true

Browse Source
This commit is contained in:
Chris
2017-01-10 16:47:09 +01:00
parent 688b9dcfca
commit 70c510ff9b
3 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/MakePhar/Application.php
View File

@ -98,7 +98,8 @@ class Application
$manifests = Manifest::createFromFile($this->config->manifest);
foreach ($manifests as $manifest) {
log_info("Building %s", $manifest->getOutput());
$type = $manifest->getIsLibrary()?"library":"application";
log_info("Building %s %s", $type, $manifest->getOutput());
$builder = new PharBuilder($manifest);
$builder->prepare();
$builder->build();

12
src/MakePhar/Manifest.php
View File

@ -57,13 +57,19 @@ class Manifest
foreach ($tag->getChildren() as $child) switch ($child->getTagName()) {
case 'library':
$mf->setIsLibrary($child->getValue()?:true);
$val = $child->getValue();
if ($val === null) $val = true;
$mf->setIsLibrary($val);
break;
case 'compress':
$mf->setCompression($child->getValue()?:true);
$val = $child->getValue();
if ($val === null) $val = true;
$mf->setCompression($val);
break;
case 'verbatim':
$mf->setVerbatim($child->getValue()?:true);
$val = $child->getValue();
if ($val === null) $val = true;
$mf->setVerbatim($val);
break;
case 'stub':
$mf->setStubFile($child->getValue());