Removed debugging code, tweaks to tests
This commit is contained in:
		
							
								
								
									
										5
									
								
								doc/ObjectUserdata.md
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										5
									
								
								doc/ObjectUserdata.md
									
									
									
									
									
										Normal file
									
								
							@@ -0,0 +1,5 @@
 | 
			
		||||
# Object UserData
 | 
			
		||||
 | 
			
		||||
There is no support for userdata on `WebSocketInterface`, `WebSocketConnection` or `ConnectionGroup`.
 | 
			
		||||
 | 
			
		||||
The rationale for this is that the connections can be easily managed using `SplObjectStorage` to link to a data object. Similarly, for groups, the names should be unique and can be used for lookups.
 | 
			
		||||
@@ -1,28 +0,0 @@
 | 
			
		||||
<?php
 | 
			
		||||
 | 
			
		||||
namespace NoccyLabs\React\WebSocket\Debug;
 | 
			
		||||
 | 
			
		||||
trait HexDumpTrait
 | 
			
		||||
{
 | 
			
		||||
 | 
			
		||||
    private function hexdump($data): void
 | 
			
		||||
    {
 | 
			
		||||
        printf("_____  *%4d\n", strlen($data));
 | 
			
		||||
        $rows = str_split($data, 16);
 | 
			
		||||
        $offs = 0;
 | 
			
		||||
        foreach ($rows as $row) {
 | 
			
		||||
            $h = []; $a = [];
 | 
			
		||||
            for ($n = 0; $n < 16; $n++) {
 | 
			
		||||
                if ($n < strlen($row)) {
 | 
			
		||||
                    $h[] = sprintf("%02x%s", ord($row[$n]), ($n==7)?"  ":" ");
 | 
			
		||||
                    $a[] = sprintf("%s%s", (ctype_print($row[$n])?$row[$n]:"."), ($n==7)?" ":"");
 | 
			
		||||
                } else {
 | 
			
		||||
                    $h[] = (($n==7)?"    ":"   ");
 | 
			
		||||
                    $a[] = (($n==7)?"  ":" ");
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
            printf("%04x | %s | %s\n", 16 * $offs++, join("", $h), join("", $a));
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
}
 | 
			
		||||
@@ -3,11 +3,14 @@
 | 
			
		||||
namespace NoccyLabs\React\WebSocket\Group;
 | 
			
		||||
 | 
			
		||||
use NoccyLabs\React\WebSocket\WebSocketConnection;
 | 
			
		||||
use NoccyLabs\React\WebSocket\WebSocketProtocol;
 | 
			
		||||
use PHPUnit\Framework\Attributes\CoversClass;
 | 
			
		||||
use React\Http\Message\ServerRequest;
 | 
			
		||||
use React\Stream\ThroughStream;
 | 
			
		||||
 | 
			
		||||
#[CoversClass(ConnectionGroup::class)]
 | 
			
		||||
#[CoversClass(WebSocketConnection::class)]
 | 
			
		||||
#[CoversClass(WebSocketProtocol::class)]
 | 
			
		||||
class ConnectionGroupTest extends \PHPUnit\Framework\TestCase
 | 
			
		||||
{
 | 
			
		||||
 | 
			
		||||
@@ -49,4 +52,4 @@ class ConnectionGroupTest extends \PHPUnit\Framework\TestCase
 | 
			
		||||
        $this->assertEquals(3, count($r));
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
}
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -6,6 +6,7 @@ use PHPUnit\Framework\Attributes\CoversClass;
 | 
			
		||||
use React\Http\Message\ServerRequest;
 | 
			
		||||
 | 
			
		||||
#[CoversClass(WebSocketMiddleware::class)]
 | 
			
		||||
#[CoversClass(WebSocketConnection::class)]
 | 
			
		||||
class WebSocketMiddlewareTest extends \PHPUnit\Framework\TestCase
 | 
			
		||||
{
 | 
			
		||||
 | 
			
		||||
@@ -54,4 +55,4 @@ class InvokableDummy
 | 
			
		||||
    public function test()
 | 
			
		||||
    {
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user